Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 100238: Linux: terminate clipboard handling on the UI thread. (Closed)

Created:
11 years, 7 months ago by agl
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: terminate clipboard handling on the UI thread. After discussing with various people, I think we're going to do this in the short term at least. Currently we're calling into GTK from the IO thread and Bad Things Happen when one does that. We would like to write an Xlib, fully asynchronous system for dealing with the clipboard (and to get the clipboard stuff out of base!). That would let us avoid sending the selection over the IPC channel each time it updates too. However, that's going to be a lot of work and we have crashing browsers happening /right now/. Also, Evan thinks that maybe we don't have the deadlock situation on Linux that we do on Windows with terminating sync requests from the renderer on the UI thread.

Patch Set 1 #

Patch Set 2 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -24 lines) Patch
M chrome/browser/renderer_host/resource_message_filter.h View 1 2 chunks +13 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 2 chunks +43 lines, -15 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter_gtk.cc View 1 6 chunks +83 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
agl
11 years, 7 months ago (2009-05-01 01:02:07 UTC) #1
Evan Martin
11 years, 7 months ago (2009-05-01 01:10:55 UTC) #2
typo in review desc: discuessing

I kinda don't understand the relative lifetimes and locks of the threads
involved here.  E.g. we have code on the IO thread that calls ui_loop().

However, if you're confident this works (even in the case of shutdown, where
some threads might be available), then it LGTM.

Powered by Google App Engine
This is Rietveld 408576698