Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 100233: Enables key view loop autorecalculation in the BrowserWindow. (Closed)

Created:
11 years, 7 months ago by rohitrao (ping after 24h)
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Enables key view loop autorecalculation in the BrowserWindow on Mac. This fixes a bug where you would cycle through a background tab's links even after selecting a different tab. The specific nib change is to check "Auto Recalculates View Loop" for the "Browser" window. TEST=Open Chromium. Open a new tab. Press tab and verify that we are correctly cycling through the links in the new tab. Committed in http://src.chromium.org/viewvc/chrome?view=rev&revision=15057

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/nibs/en.lproj/BrowserWindow.xib View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
rohitrao (ping after 24h)
The word "tab" is completely overloaded, so let me know if the CL description makes ...
11 years, 7 months ago (2009-04-30 23:49:57 UTC) #1
Avi (use Gerrit)
LVGTM
11 years, 7 months ago (2009-04-30 23:58:01 UTC) #2
rohitrao (ping after 24h)
On 2009/04/30 23:58:01, Avi wrote: > LVGTM Experimentation showed that we weren't autorecalculating, and most ...
11 years, 7 months ago (2009-05-01 15:05:50 UTC) #3
Avi (use Gerrit)
11 years, 7 months ago (2009-05-01 16:05:36 UTC) #4
Seems to work. LGTM.

http://codereview.chromium.org/100233/diff/1002/1003
File chrome/app/nibs/en.lproj/BrowserWindow.xib (right):

http://codereview.chromium.org/100233/diff/1002/1003#newcode41
Line 41: <int key="NSWTFlags">536872960</int>
This changes the flags from 0x20000000 to 0x20000030. Next time, can you comment
on the meaning (e.g. "I checked the FooBar property on the containing view")?

Powered by Google App Engine
This is Rietveld 408576698