POSIX: Don't allow onunload handlers to hang a renderer forever.

POSIX: Don't allow onunload handlers to hang a renderer forever.

On POSIX one can install an unload handler which loops forever and
leave behind a renderer process which eats 100% CPU forever.

This is because the terminate signals (ViewMsg_ShouldClose and the
error from the IPC channel) are routed to the main message loop but
never processes (because that message loop is stuck in V8).

One could make the browser SIGKILL the renderers, but that leaves open
a large window where a browser failure (or a user, manually
terminating the browser because "it's stuck") will leave behind a
process eating all the CPU.

On Windows we don't have this issue because all the processes are in a
job so when the parent dies, all the children are killed too.

[Evan Stade, 2009-04-30 21:40:42]

http://codereview.chromium.org/100222/diff/1/4
File chrome/renderer/render_thread.cc (right):

http://codereview.chromium.org/100222/diff/1/4#newcode106
Line 106: class SuicideOnChannelErrorFilter : public
IPC::ChannelProxy::MessageFilter {
lol at this name

[jam, 2009-04-30 22:15:43]

lgtm

do you want to make that filter a member of RenderThread to avoid memory leak
warnings?