Replace the index mapping of wallpaper picker UI and hard coded wallpaper index in C++

chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler2.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler2.h"
 
 #include "ash/desktop_background/desktop_background_controller.h"
 #include "ash/desktop_background/desktop_background_resources.h"
 #include "ash/shell.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/views/window.h"
-#include "chrome/browser/ui/webui/web_ui_util.h"
+#include "chrome/browser/ui/webui/options2/chromeos/wallpaper_thumbnail_source2.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/web_ui.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/views/widget/widget.h"
 
 namespace chromeos {
 namespace options2 {
@@ skipping 25 matching lines @@
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("selectWallpaper",
       base::Bind(&SetWallpaperOptionsHandler::HandleSelectImage,
                  base::Unretained(this)));
 }
 
 void SetWallpaperOptionsHandler::SendDefaultImages() {
   ListValue images;
   DictionaryValue* image_detail;
   ash::WallpaperInfo image_info;
-

[James Hawkins, 2012/04/20 19:40:17]

Please don't make random whitespace changes like this.

[bshe, 2012/04/20 21:11:43]

Sorry. Didn't notice it. Thanks.

On 2012/04/20 19:40:17, James Hawkins wrote:

   for (int i = 0; i < ash::GetWallpaperCount(); ++i) {
     images.Append(image_detail = new DictionaryValue());
     image_info = ash::GetWallpaperInfo(i);
-    image_detail->SetString("url", web_ui_util::GetImageDataUrl(
-        ash::GetWallpaperThumbnail(i)));
+    image_detail->SetString("url", GetDefaultWallpaperThumbnailURL(i));
     image_detail->SetString("author", image_info.author);
     image_detail->SetString("website", image_info.website);
   }
 
   web_ui()->CallJavascriptFunction("SetWallpaperOptions.setDefaultImages",
                                    images);
 }
 
 void SetWallpaperOptionsHandler::HandlePageInitialized(
     const base::ListValue* args) {
   DCHECK(args && args->empty());
 
   SendDefaultImages();
 }
 
 void SetWallpaperOptionsHandler::HandlePageShown(const base::ListValue* args) {
   DCHECK(args && args->empty());
   int index = chromeos::UserManager::Get()->GetUserWallpaperIndex();
-  base::FundamentalValue index_value(index);
+  base::StringValue image_url(GetDefaultWallpaperThumbnailURL(index));
   web_ui()->CallJavascriptFunction("SetWallpaperOptions.setSelectedImage",
-                                   index_value);
+                                   image_url);
 }
 
 void SetWallpaperOptionsHandler::HandleSelectImage(const ListValue* args) {
-  std::string image_index_string;
-  int image_index;
+  std::string image_url;
   if (!args ||
       args->GetSize() != 1 ||
-      !args->GetString(0, &image_index_string) ||
-      !base::StringToInt(image_index_string, &image_index) ||
-      image_index < 0 || image_index >= ash::GetWallpaperCount())
+      !args->GetString(0, &image_url))
     NOTREACHED();
 
-  UserManager::Get()->SaveUserWallpaperIndex(image_index);
-  ash::Shell::GetInstance()->desktop_background_controller()->
-      SetDesktopBackgroundImageMode();
+  if (image_url.empty())
+    return;
+
+  int user_image_index;
+  if (IsDefaultWallpaperURL(image_url, &user_image_index)) {
+    UserManager::Get()->SaveUserWallpaperIndex(user_image_index);
+    ash::Shell::GetInstance()->desktop_background_controller()->
+        SetDesktopBackgroundImageMode();
+  }
 }
 
 gfx::NativeWindow SetWallpaperOptionsHandler::GetBrowserWindow() const {
   Browser* browser =
       BrowserList::FindBrowserWithProfile(Profile::FromWebUI(web_ui()));
   if (!browser)
     return NULL;
   return browser->window()->GetNativeHandle();
 }
 
 }  // namespace options2
 }  // namespace chromeos