Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 100210: Relanding in-progress download bug fix (Closed)

Created:
11 years, 7 months ago by jcampan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Relanding this, it was missing the Mac unit-test change, that was breaking the build. TBR=ben Closing the last tab with a download in-progress would cause the tab to be closed and become unusable if the user decides not to proceed with the browser shutdown. This is because we check for in-progress downloads when the browser is closed, and the tab is closed before that, leaving the tab-strip in a bad state. This CL ensures we also bring-up the confirmation dialog when the last tab is closed. BUG=10680 TEST=Start downloading a big file. While the file is downloading, close all tabs. When closing the last tab, the in-progress download dialog should be shown. Select the 'Wait for downloads', the download tab should be shown and the previous tab should still be displayed and functional. Close all tabs again, this time select the 'Close and cancel downloads' option, the browser should be closed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -8 lines) Patch
M chrome/browser/browser.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/tab_strip_controller_unittest.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.h View 5 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 3 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698