Issue 100206: Initial prefs window xib from Cole. Hook the menu up to (empty) code. Use sco...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100206: Initial prefs window xib from Cole. Hook the menu up to (empty) code. Use sco... (Closed)

Created:
11 years, 7 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Initial prefs window xib from Cole. Hook the menu up to (empty) code. Use scoped pointers to manage memory. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14945

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3836 lines, -14 lines)			Patch
M	chrome/app/nibs/en.lproj/MainMenu.xib	View	5 chunks	+22 lines, -5 lines	0 comments	Download
A	chrome/app/nibs/en.lproj/Preferences.xib	View	1 chunk	+3791 lines, -0 lines	2 comments	Download
M	chrome/browser/app_controller_mac.h	View	1 chunk	+12 lines, -5 lines	0 comments	Download
M	chrome/browser/app_controller_mac.mm	View	5 chunks	+10 lines, -4 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

TVL

lgtm http://codereview.chromium.org/100206/diff/6/1006 File chrome/app/nibs/en.lproj/Preferences.xib (right): http://codereview.chromium.org/100206/diff/6/1006#newcode335 Line 335: QXBwbGUgQ29tcHV0ZXIsIEluYy4sIDIwMDUAAAAAA</bytes> any way we can avoid these ...

11 years, 7 months ago (2009-04-30 15:06:40 UTC) #2

pink (ping after 24hrs)

11 years, 7 months ago (2009-04-30 15:15:39 UTC) #3

http://codereview.chromium.org/100206/diff/6/1006
File chrome/app/nibs/en.lproj/Preferences.xib (right):

http://codereview.chromium.org/100206/diff/6/1006#newcode335
Line 335: QXBwbGUgQ29tcHV0ZXIsIEluYy4sIDIwMDUAAAAAA</bytes>
On 2009/04/30 15:06:40, TVL wrote:
> any way we can avoid these images getting dumped into the xib?

Alas, no, NSMatrix likes to cache its representation. Radar bug filed, according
to Cole.

Expand Messages | Collapse Messages

Issue 100206: Initial prefs window xib from Cole. Hook the menu up to (empty) code. Use sco... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages