Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Side by Side Diff: chrome/browser/gtk/browser_window_gtk.cc

Issue 100203: Implement a mostly working InfoBubble with a shim BookmarkBubble. (Closed)
Patch Set: Comments Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/gtk/browser_window_gtk.h" 5 #include "chrome/browser/gtk/browser_window_gtk.h"
6 6
7 #include <gdk/gdkkeysyms.h> 7 #include <gdk/gdkkeysyms.h>
8 8
9 #include "base/base_paths_linux.h" 9 #include "base/base_paths_linux.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 void BrowserWindowGtk::ShowAboutChromeDialog() { 480 void BrowserWindowGtk::ShowAboutChromeDialog() {
481 ShowAboutDialogForProfile(window_, browser_->profile()); 481 ShowAboutDialogForProfile(window_, browser_->profile());
482 } 482 }
483 483
484 void BrowserWindowGtk::ShowBookmarkManager() { 484 void BrowserWindowGtk::ShowBookmarkManager() {
485 NOTIMPLEMENTED(); 485 NOTIMPLEMENTED();
486 } 486 }
487 487
488 void BrowserWindowGtk::ShowBookmarkBubble(const GURL& url, 488 void BrowserWindowGtk::ShowBookmarkBubble(const GURL& url,
489 bool already_bookmarked) { 489 bool already_bookmarked) {
490 NOTIMPLEMENTED(); 490 toolbar_->star()->ShowStarBubble(url, !already_bookmarked);
491 } 491 }
492 492
493 void BrowserWindowGtk::ShowReportBugDialog() { 493 void BrowserWindowGtk::ShowReportBugDialog() {
494 NOTIMPLEMENTED(); 494 NOTIMPLEMENTED();
495 } 495 }
496 496
497 void BrowserWindowGtk::ShowClearBrowsingDataDialog() { 497 void BrowserWindowGtk::ShowClearBrowsingDataDialog() {
498 NOTIMPLEMENTED(); 498 NOTIMPLEMENTED();
499 } 499 }
500 500
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
705 } else { 705 } else {
706 browser_window->ExecuteBrowserCommand(command_id); 706 browser_window->ExecuteBrowserCommand(command_id);
707 } 707 }
708 708
709 return TRUE; 709 return TRUE;
710 } 710 }
711 711
712 void BrowserWindowGtk::ExecuteBrowserCommand(int id) { 712 void BrowserWindowGtk::ExecuteBrowserCommand(int id) {
713 browser_->ExecuteCommand(id); 713 browser_->ExecuteCommand(id);
714 } 714 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698