Open a login tab on captive portal detection on SSL loads.

chrome/browser/captive_portal/captive_portal_login_detector.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_LOGIN_DETECTOR_H_
+#define CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_LOGIN_DETECTOR_H_
+#pragma once
+
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"

[cbentzel, 2012/05/30 16:26:42]

Where is compiler_specific userd?

[mmenke, 2012/05/30 17:46:25]

Removed.  OVERRIDE and DISALLOW_COPY_AND_ASSIGN being in different, randomly
named headers always confuses me.

+#include "chrome/browser/captive_portal/captive_portal_service.h"
+
+class Profile;
+
+namespace captive_portal {
+
+// Triggers a captive portal test on navigations that may indicate a captive
+// portal has been logged into.  Currently only tracks if a page was opened
+// at a captive portal tab's login page, and triggers checks every navigation
+// until there's no longer a captive portal, relying on the
+// CaptivePortalService's throttling to prevent excessive server load.
+//
+// TODO(mmenke):  If a page has been broken by a captive portal, and it's
+// successfully reloaded, trigger a captive portal check.
+class CaptivePortalLoginDetector {
+ public:
+  explicit CaptivePortalLoginDetector(Profile* profile);
+
+  virtual ~CaptivePortalLoginDetector();

[cbentzel, 2012/05/30 16:26:42]

Why does this need to be virtual? 

[mmenke, 2012/05/30 17:46:25]

Removed.

+
+  void OnStoppedLoading();
+  void OnCaptivePortalResults(Result previous_result, Result result);
+
+  bool is_login_tab() const { return is_login_tab_; }
+  void set_is_login_tab() { is_login_tab_ = true; }
+
+ private:
+  Profile* profile_;
+
+  // True if this is a login tab.  Set manually, automatically cleared once
+  // login is detected.
+  bool is_login_tab_;
+
+  DISALLOW_COPY_AND_ASSIGN(CaptivePortalLoginDetector);
+};
+
+}  // namespace captive_portal
+
+#endif  // CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_LOGIN_DETECTOR_H_