Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 10020048: Work on USE_ASH/USE_AURA split. (Closed)

Created:
8 years, 8 months ago by Elliot Glaysher
Modified:
8 years, 8 months ago
CC:
chromium-reviews, robertshield, kkania, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Work on USE_ASH/USE_AURA split. This reduced link errors in the chrome binary down to roughly ten. - Supplies an X11 implementation of parts of gfx::Screen. - Multiple files renamed from _aura.cc to _ash.cc or placed outside of ash only directories. - Some random usage #ifdefed properly. BUG=116458 TEST=Everything still compiles in all different configurations. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131900

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -881 lines) Patch
M ash/wm/custom_frame_view_ash.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider_aura.cc View 1 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/pepper_gtalk_message_filter.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/platform_util_aura.cc View 2 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/gesture_prefs_observer_factory_aura.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/gesture_prefs_observer_factory_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc View 18 chunks +29 lines, -29 lines 0 comments Download
D chrome/browser/ui/views/ash/gesture_prefs_observer_factory_aura.h View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/ui/views/ash/gesture_prefs_observer_factory_aura.cc View 1 2 1 chunk +0 lines, -224 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.h View 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc View 1 chunk +0 lines, -452 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc View 1 3 chunks +14 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 5 chunks +11 lines, -8 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
A ui/gfx/screen_aurax11.cc View 1 chunk +102 lines, -0 lines 0 comments Download
M ui/ui.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
8 years, 8 months ago (2012-04-11 21:49:43 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 8 months ago (2012-04-11 22:06:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10020048/1022
8 years, 8 months ago (2012-04-11 22:40:38 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-12 02:09:19 UTC) #4
Change committed as 131900

Powered by Google App Engine
This is Rietveld 408576698