Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 10020014: Update uses of TimeDelta in chrome/installer. (Closed)

Created:
8 years, 8 months ago by Ted Vessenes
Modified:
8 years, 8 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Update uses of TimeDelta in chrome/installer. R=grt@chromium.org BUG=108171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132360

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/installer/setup/setup_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/copy_tree_work_item_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Ted Vessenes
8 years, 8 months ago (2012-04-09 02:35:43 UTC) #1
grt (UTC plus 2)
lgtm, thanks. https://chromiumcodereview.appspot.com/10020014/diff/1/chrome/installer/setup/setup_util_unittest.cc File chrome/installer/setup/setup_util_unittest.cc (right): https://chromiumcodereview.appspot.com/10020014/diff/1/chrome/installer/setup/setup_util_unittest.cc#newcode1 chrome/installer/setup/setup_util_unittest.cc:1: // Copyright (c) 2011 The Chromium Authors. ...
8 years, 8 months ago (2012-04-10 14:12:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10020014/1
8 years, 8 months ago (2012-04-10 14:17:16 UTC) #3
commit-bot: I haz the power
Try job failure for 10020014-1 (retry) on win_rel for step "update". It's a second try, ...
8 years, 8 months ago (2012-04-10 14:20:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10020014/1
8 years, 8 months ago (2012-04-11 02:44:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10020014/15001
8 years, 8 months ago (2012-04-15 03:52:16 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-15 06:33:19 UTC) #7
Change committed as 132360

Powered by Google App Engine
This is Rietveld 408576698