DevTools: Implement styles editing.

webkit/glue/devtools/js/dom_agent.js

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Dom and DomNode are used to represent remote DOM in the
  * web inspector.
  */
 goog.provide('devtools.DomAgent');
 goog.provide('devtools.DomDocument');
@@ skipping 811 matching lines @@
 /**
  * Returns all properties of the given node.
  * @param {number} nodeId Node to get properties for.
  * @param {Array.<string>} path Path to the object.
  * @param {number} protoDepth Depth to the exact proto level.
  * @param {function(string):undefined} callback Function to call with the
  *     result.
  */
 devtools.DomAgent.prototype.getNodePropertiesAsync = function(nodeId,
     path, protoDepth, callback) {
-  var mycallback =
-      goog.bind(this.utilityFunctionCallbackWrapper_, this, callback);
-  var callbackId = devtools.Callback.wrap(mycallback);
+  var callbackId = this.utilityFunctionCallbackWrapper_(callback);
   RemoteToolsAgent.ExecuteUtilityFunction(callbackId,
       'getProperties', nodeId,
       goog.json.serialize([path, protoDepth]));
 };
 
 
 /**
  * Returns prototype chain for a given node.
  * @param {number} nodeId Node to get prototypes for.
  * @param {Function} callback.
  */
 devtools.DomAgent.prototype.getNodePrototypesAsync = function(nodeId,
     callback) {
-  var mycallback =
-      goog.bind(this.utilityFunctionCallbackWrapper_, this, callback);
-  var callbackId = devtools.Callback.wrap(mycallback);
+  var callbackId = this.utilityFunctionCallbackWrapper_(callback);
   RemoteToolsAgent.ExecuteUtilityFunction(callbackId,
       'getPrototypes', nodeId, '[]');
 };
 
 
 /**
  * Returns styles for given node.
  * @param {devtools.DomNode} node Node to get prototypes for.
  * @param {boolean} authorOnly Returns only author styles if true.
  * @param {Function} callback.
  */
 devtools.DomAgent.prototype.getNodeStylesAsync = function(node,
     authorOnly, callback) {
-  var mycallback =
-      goog.bind(this.utilityFunctionCallbackWrapper_, this, callback);
-  var callbackId = devtools.Callback.wrap(mycallback);
+  var callbackId = this.utilityFunctionCallbackWrapper_(callback);
   RemoteToolsAgent.ExecuteUtilityFunction(callbackId,
       'getStyles',
       node.id_,
       goog.json.serialize([authorOnly]));
 };
 
 
 /**
  * Toggles style with given id on/off.
  * @param {devtools.CSSStyleDeclaration} style Style to toggle.
  * @param {boolean} enabled True if style should be enabled.
  * @param {string} name Style name.
  * @param {Function} callback.
  */
 devtools.DomAgent.prototype.toggleNodeStyleAsync = function(
     style, enabled, name, callback) {
-  var mycallback =
-      goog.bind(this.utilityFunctionCallbackWrapper_, this, callback);
-  var callbackId = devtools.Callback.wrap(mycallback);
+  var callbackId = this.utilityFunctionCallbackWrapper_(callback);
   RemoteToolsAgent.ExecuteUtilityFunction(callbackId,
       'toggleNodeStyle',
       style.nodeId_,
       goog.json.serialize([style.id_, enabled, name]));
 };
 
 
 /**
+ * Applies new text to a style.
+ * @param {devtools.CSSStyleDeclaration} style Style to edit.
+ * @param {string} name Property name to edit.
+ * @param {string} styleText Text to set the style from.
+ * @param {Function} callback.
+ */
+devtools.DomAgent.prototype.applyStyleTextAsync = function(
+    style, name, styleText, callback) {
+  var callbackId = this.utilityFunctionCallbackWrapper_(callback);
+  RemoteToolsAgent.ExecuteUtilityFunction(callbackId,

[yurys, 2009/04/30 09:55:40]

style: wrong arguments alignment

[pfeldman, 2009/04/30 10:00:16]

Done.

+      'applyStyleText',
+      style.nodeId_,
+      goog.json.serialize([style.id_, name, styleText]));
+};
+
+
+/**
  * Dumps exception if something went wrong in ExecuteUtilityFunction.
+ * @param {Function} callback Callback to wrap.
+ * @return {number} Callback id.
  */
 devtools.DomAgent.prototype.utilityFunctionCallbackWrapper_ =
-    function(callback, result, exception) {
-  if (exception && exception.length) {
-    debugPrint('Exception in ExecuteUtilityFunction styles:' + exception);
-    return;
-  }
-  callback(result);
+    function(callback) {
+  var mycallback = function(result, exception) {
+    if (exception && exception.length) {
+      debugPrint('Exception in ExecuteUtilityFunction styles:' + exception);
+      return;
+    }
+    callback(result);
+  };
+  return devtools.Callback.wrap(mycallback);
 };
 
 
 /**
  * Represents remote CSSStyleDeclaration for using in StyleSidebarPane.
  * @param {id, Array<Object>} payload built by inject's getStyle from the
  *     injected js.
  * @constructor
  */
 devtools.CSSStyleDeclaration = function(payload) {
@@ skipping 66 matching lines @@
 function onlyTextChild() {
   if (!this.children) {
     return null;
   } else if (this.children.length == 1 &&
         this.children[0].nodeType == Node.TEXT_NODE) {
     return this.children[0];
   } else {
     return null;
   }
 }