Issue 100199: DevTools: Implement styles editing.

Issue 100199: DevTools: Implement styles editing. (Closed)

Created:
11 years, 7 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: Implement styles editing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14936

Patch Set 1 #

Total comments: 6

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+232 lines, -48 lines)			Patch
M	webkit/glue/devtools/js/devtools.js	View	1 chunk	+18 lines, -3 lines	2 comments	Download
M	webkit/glue/devtools/js/devtools_host_stub.js	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	webkit/glue/devtools/js/dom_agent.js	View	5 chunks	+32 lines, -18 lines	2 comments	Download
M	webkit/glue/devtools/js/inject.js	View	5 chunks	+179 lines, -25 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

LGTM as long as the style comments are addressed. http://codereview.chromium.org/100199/diff/1/5 File webkit/glue/devtools/js/devtools.js (right): http://codereview.chromium.org/100199/diff/1/5#newcode582 Line ...

11 years, 7 months ago (2009-04-30 09:55:40 UTC) #2

pfeldman

11 years, 7 months ago (2009-04-30 10:00:16 UTC) #3

http://codereview.chromium.org/100199/diff/1/5
File webkit/glue/devtools/js/devtools.js (right):

http://codereview.chromium.org/100199/diff/1/5#newcode582
Line 582: devtools.tools.getDomAgent().applyStyleTextAsync(this.style,
this.name,
On 2009/04/30 09:55:40, Yury Semikhatsky wrote:
> style: each param on its own line

Done.

http://codereview.chromium.org/100199/diff/1/4
File webkit/glue/devtools/js/dom_agent.js (right):

http://codereview.chromium.org/100199/diff/1/4#newcode895
Line 895: RemoteToolsAgent.ExecuteUtilityFunction(callbackId,
On 2009/04/30 09:55:40, Yury Semikhatsky wrote:
> style: wrong arguments alignment

Done.

http://codereview.chromium.org/100199/diff/1/3
File webkit/glue/devtools/js/inject.js (right):

http://codereview.chromium.org/100199/diff/1/3#newcode281
Line 281: devtools.Injected.prototype.applyStyleText = function(node, styleId,
On 2009/04/30 09:55:40, Yury Semikhatsky wrote:
> wrong parameter alignment here and in some other places, please fix

Lets better stick to this schema!

Expand Messages | Collapse Messages