Issue 100196: A quick fix for supporting bidirectional texts in omnibox2....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100196: A quick fix for supporting bidirectional texts in omnibox2.... (Closed)

Created:
11 years, 7 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A quick fix for supporting bidirectional texts in omnibox2. It seems the AutocompleteResultView::DrawString() function calls the AutocompleteResultView::DrawStringFragment() function even when |text_start| is greater than |text_end|, i.e. there are not matching characters. This change filters out the above case and fixes a couple of lint errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14933

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc	View		3 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages