Enable video in linux build and remove unneeded ifdefs to guard windows.

Enable video in posix builds and remove unneeded ifdefs to guard windows.

The code still crashes when trying to play a video, but this will allow debugging.

[awong, 2009-04-30 02:16:41]

Remove conditional compiles and other stuff like that.

Anyone know if I need to get someone else to look over the .gyp changes?

I think they're safe.

[scherkus (not reviewing), 2009-04-30 04:19:07]

http://codereview.chromium.org/100195/diff/22/1002
File chrome/renderer/webmediaplayer_delegate_impl.cc (right):

http://codereview.chromium.org/100195/diff/22/1002#newcode15
Line 15: // FFmpeg is not ready for Linux and Mac yet.
can get rid of this comment

http://codereview.chromium.org/100195/diff/22/1002#newcode67
Line 67: // FFmpeg is not ready for Linux and Mac yet.
can get rid of both these comments

http://codereview.chromium.org/100195/diff/22/1003
File media/base/media_posix.cc (right):

http://codereview.chromium.org/100195/diff/22/1003#newcode101
Line 101: int (*av_seek_frame_ptr)(AVFormatContext* s, int stream_index,
not sure, but it looks like you have a space between different groups of
function pointers

http://codereview.chromium.org/100195/diff/22/1003#newcode117
Line 117: void (*av_free_ptr)(void* ptr) = NULL;
space here?

http://codereview.chromium.org/100195/diff/22/1003#newcode242
Line 242: if (avcodec_init_ptr &&
can you add in a check for av_get_bits_per_sample_format_ptr

looks like we both missed it :)

http://codereview.chromium.org/100195/diff/22/1006
File media/filters/ffmpeg_glue.cc (right):

http://codereview.chromium.org/100195/diff/22/1006#newcode108
Line 108: av_register_protocol(&kFFmpegProtocol);
strange... any clues why we weren't getting linker errors before?

http://codereview.chromium.org/100195/diff/22/1008
File webkit/webkit.gyp (right):

http://codereview.chromium.org/100195/diff/22/1008#newcode22
Line 22: 'ENABLE_VIDEO=1'
so when you say "Enable video in linux build" I guess you really mean posix?

[awong, 2009-05-01 18:18:05]

http://codereview.chromium.org/100195/diff/22/1002
File chrome/renderer/webmediaplayer_delegate_impl.cc (right):

http://codereview.chromium.org/100195/diff/22/1002#newcode15
Line 15: // FFmpeg is not ready for Linux and Mac yet.
On 2009/04/30 04:19:07, scherkus wrote:
> can get rid of this comment

Done.

http://codereview.chromium.org/100195/diff/22/1002#newcode67
Line 67: // FFmpeg is not ready for Linux and Mac yet.
On 2009/04/30 04:19:07, scherkus wrote:
> can get rid of both these comments

Done.

http://codereview.chromium.org/100195/diff/22/1003
File media/base/media_posix.cc (right):

http://codereview.chromium.org/100195/diff/22/1003#newcode101
Line 101: int (*av_seek_frame_ptr)(AVFormatContext* s, int stream_index,
On 2009/04/30 04:19:07, scherkus wrote:
> not sure, but it looks like you have a space between different groups of
> function pointers

Done.

http://codereview.chromium.org/100195/diff/22/1003#newcode117
Line 117: void (*av_free_ptr)(void* ptr) = NULL;
On 2009/04/30 04:19:07, scherkus wrote:
> space here?

Done.

http://codereview.chromium.org/100195/diff/22/1003#newcode242
Line 242: if (avcodec_init_ptr &&
On 2009/04/30 04:19:07, scherkus wrote:
> can you add in a check for av_get_bits_per_sample_format_ptr
> 
> looks like we both missed it :)

Done.

http://codereview.chromium.org/100195/diff/22/1006
File media/filters/ffmpeg_glue.cc (right):

http://codereview.chromium.org/100195/diff/22/1006#newcode108
Line 108: av_register_protocol(&kFFmpegProtocol);
On 2009/04/30 04:19:07, scherkus wrote:
> strange... any clues why we weren't getting linker errors before?

the register_protocol api is deprecated.  I think they just renamed it.  With
the deprecation, it doesn't compile in linux land (warning treated as error.
:-/)

http://codereview.chromium.org/100195/diff/22/1008
File webkit/webkit.gyp (right):

http://codereview.chromium.org/100195/diff/22/1008#newcode22
Line 22: 'ENABLE_VIDEO=1'
On 2009/04/30 04:19:07, scherkus wrote:
> so when you say "Enable video in linux build" I guess you really mean posix?

yep. :)

[awong, 2009-05-01 21:15:05]

more fixes.  This ends up actually making video work.  yay.

[scherkus (not reviewing), 2009-05-01 23:04:19]

LGTM