Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2107)

Unified Diff: chrome/browser/extensions/extension_host.cc

Issue 100182: Fix race where sometimes CSS is not applied to toolstrips. I (Closed)
Patch Set: Merged Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_host.cc
diff --git a/chrome/browser/extensions/extension_host.cc b/chrome/browser/extensions/extension_host.cc
index 16d55e8e847732a7ca27637b8d4b0dc3629c4130..509810ba741615cfa3be25f290326e7375e01cf6 100755
--- a/chrome/browser/extensions/extension_host.cc
+++ b/chrome/browser/extensions/extension_host.cc
@@ -78,16 +78,17 @@ void ExtensionHost::RunJavaScriptMessage(
render_view_host()->JavaScriptMessageBoxClosed(reply_msg, true, L"");
}
-void ExtensionHost::DidStartLoading(RenderViewHost* render_view_host) {
+void ExtensionHost::DidStopLoading(RenderViewHost* render_view_host) {
+ // TODO(aa): This is toolstrip-specific and should probably not be here.
+ // ExtensionToolstrip in bookmark_bar_view.cc?
static const StringPiece toolstrip_css(
ResourceBundle::GetSharedInstance().GetRawDataResource(
IDR_EXTENSIONS_TOOLSTRIP_CSS));
render_view_host->InsertCSSInWebFrame(L"", toolstrip_css.as_string());
-}
-void ExtensionHost::DidStopLoading(RenderViewHost* render_view_host) {
render_view_host->WasResized();
did_stop_loading_ = true;
+
if (view_)
view_->ShowIfCompletelyLoaded();
}
« no previous file with comments | « chrome/browser/extensions/extension_host.h ('k') | chrome/test/data/extensions/samples/bookmarks/bookmark_api.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698