Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 100182: Fix race where sometimes CSS is not applied to toolstrips. I (Closed)

Created:
11 years, 7 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix race where sometimes CSS is not applied to toolstrips. I think this was happening because we were injecting from the the browser at load_start, but the document might not be established in the renderer by the time this message is received. Since we are now not even showing the toolstrip until load_complete, it is no big deal to delay the CSS injection until then.

Patch Set 1 #

Patch Set 2 : Revert changes to samples, will wait until next dev release for that #

Patch Set 3 : Remove extensions_toolstrip.css again, moved crx files to wiki #

Patch Set 4 : Forgot file #

Patch Set 5 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -361 lines) Patch
M chrome/browser/extensions/extension_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/samples/bookmarks/bookmark_api.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/samples/bookmarks/extensions_toolstrip.css View 1 chunk +0 lines, -89 lines 0 comments Download
M chrome/test/data/extensions/samples/buildbot.crx View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/extensions/samples/buildbot/buildbot.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/samples/buildbot/extensions_toolstrip.css View 1 chunk +0 lines, -89 lines 0 comments Download
M chrome/test/data/extensions/samples/gmail.crx View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/extensions/samples/gmail/extensions_toolstrip.css View 1 chunk +0 lines, -89 lines 0 comments Download
M chrome/test/data/extensions/samples/gmail/gmail_checker.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/samples/subscribe.crx View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/extensions/samples/subscribe/extensions_toolstrip.css View 1 chunk +0 lines, -89 lines 0 comments Download
M chrome/test/data/extensions/samples/subscribe/toolstrip.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Aaron Boodman
11 years, 7 months ago (2009-04-29 22:11:58 UTC) #1
Erik does not do reviews
11 years, 7 months ago (2009-04-29 22:21:43 UTC) #2
LGTM

great!

Powered by Google App Engine
This is Rietveld 408576698