Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Issue 100180: Added audio/mpeg and video/mpeg to the list of mime types supported by the Ac... (Closed)

Created:
11 years, 7 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Added audio/mpeg and video/mpeg to the list of mime types supported by the Activex shim for media player along with their associated extensions. This fixes http://code.google.com/p/chromium/issues/detail?id=11054, which occurs with embed tags with a source URL and no mime type. In this case the URL extension is mp3, which is not claimed by any plugin although Quicktime and media player do handle it. It works in Firefox because the plugin instantiation code in FF correctly gets the mime type from the http stream and instantiates the plugin accordingly. Webkit attempts to instantiate the plugin from the embed tag with the source URL. This fails silently in Chrome and Safari displays an error message. With this fix the only user visible difference would be quicktime handling the mp3 in FF and IE, and media player handling it in Chrome. I also moved the media player shim to the end of the plugin list to ensure it does not take over the audio/mpeg and video/mpeg mime types if there is a a plugin which can handle it. Added plugin tests for the mp3 and mpe extensions. Bug=11054 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15008

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M chrome/test/plugin/plugin_test.cpp View 1 chunk +9 lines, -0 lines 1 comment Download
M webkit/glue/plugins/plugin_list.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/plugins/plugin_list_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
11 years, 7 months ago (2009-04-29 21:50:02 UTC) #1
jam
11 years, 7 months ago (2009-04-30 19:55:51 UTC) #2
lgtm

http://codereview.chromium.org/100180/diff/1/4
File chrome/test/plugin/plugin_test.cpp (right):

http://codereview.chromium.org/100180/diff/1/4#newcode229
Line 229: TestActiveX(L"mp3_test.html", kLongWaitTimeout, false);
where is this file?  ditto for below

Powered by Google App Engine
This is Rietveld 408576698