Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 100179: Merge 14891 - A better fix for http://www.crbug.com/2044: crash... (Closed)

Created:
11 years, 7 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
Stephen White
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/172/src/
Visibility:
Public.

Description

Merge 14891 - A better fix for http://www.crbug.com/2044: crash on large <canvas> elements. We disable the __debugbreak only when skia tells us it is prepared to correctly handle a failed (NULL) malloc(). It does this by calling sk_malloc_flags() without SK_MALLOC_THROW. Note that, since the switch to tcmalloc, the new_handler was not getting called at all (since tcmalloc doesn't support it yet), so this crash is currently unreproducible in trunk. In order to test this change, I reverted the tcmalloc change in my client. This is not the case in the stable branch, since it doesn't use tcmalloc, so this change is still needed there. (It will also be needed in trunk again once mbelshe's reimplementation of the new_handler is in). BUG=http://www.crbug.com/2044 Review URL: http://codereview.chromium.org/100163 TBR=senorblanco@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14895

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
MM chrome/app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
MM chrome/app/chrome_dll_main.cc View 2 chunks +7 lines, -0 lines 0 comments Download
MM skia/corecg/SkMemory_stdlib.cpp View 3 chunks +12 lines, -0 lines 0 comments Download
MM skia/include/corecg/SkTypes.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 7 months ago (2009-04-29 21:48:08 UTC) #1
Stephen White
11 years, 7 months ago (2009-04-29 22:24:53 UTC) #2
In the Stable branch (which I think is where we are?), in chrome_dll_main.cc,
the "return" should be "return 0".

Powered by Google App Engine
This is Rietveld 408576698