chrome/browser/automation/automation_provider.cc - Issue 100172: Avoid null ptr access in AutomationProvider::GetTabTitle(), fixes http://crbug.com/11132,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_provider.cc

Issue 100172: Avoid null ptr access in AutomationProvider::GetTabTitle(), fixes http://crbug.com/11132,... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/automation/automation_provider.cc

===================================================================

--- chrome/browser/automation/automation_provider.cc (revision 14861)

+++ chrome/browser/automation/automation_provider.cc (working copy)

@@ -1747,7 +1747,11 @@

*title_string_size = -1; // -1 is the error code

if (tab_tracker_->ContainsHandle(handle)) {

NavigationController* tab = tab_tracker_->GetResource(handle);

- *title = UTF16ToWideHack(tab->GetActiveEntry()->title());

+ NavigationEntry* entry = tab->GetActiveEntry();

+ *title = std::wstring();

+ if (entry != NULL) {

+ *title = UTF16ToWideHack(entry->title());

+ }

*title_string_size = static_cast<int>(title->size());

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »