Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 100168: chrome.gyp updates: (Closed)

Created:
11 years, 7 months ago by sgk
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com, jcampan
Visibility:
Public.

Description

chrome.gyp updates: * remove chrome\browser\views\find_bar_win_unittest.cc * add Windows-only test targets: ** interactive_ui_tests ** plugin_tests ** selenium_tests * Move from unit_tests to test_support_common: ** test/in_process_browser_test.{cc,h} ** test/ui_test_utils.{cc,h} Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15045

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -11 lines) Patch
M chrome/chrome.gyp View 1 7 chunks +104 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sgk
We'll also need to add your new targets (.vcproj files) to the chrome.gyp file, but ...
11 years, 7 months ago (2009-04-29 19:12:28 UTC) #1
sgk
ping
11 years, 7 months ago (2009-04-30 22:52:04 UTC) #2
sgk
(hijacking a CL that started out as just removing find_bar_win_unittest.cc for adding additional targets)
11 years, 7 months ago (2009-04-30 23:59:11 UTC) #3
jcampan
LGTM (I am pretty new to Gyp).
11 years, 7 months ago (2009-05-01 00:23:49 UTC) #4
bradn
LGTM
11 years, 7 months ago (2009-05-01 00:23:54 UTC) #5
Mark Mentovai
11 years, 7 months ago (2009-05-01 00:25:07 UTC) #6
LG

Powered by Google App Engine
This is Rietveld 408576698