Issue 100159: DevTools: keep links on the edited styles so that they are not collected betw...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100159: DevTools: keep links on the edited styles so that they are not collected betw... (Closed)

Created:
11 years, 7 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: keep links on the edited styles so that they are not collected between debugging sessions. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14844

Patch Set 3 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+361 lines, -342 lines)			Patch
M	webkit/glue/devtools/debugger_agent_impl.h	View		2 chunks	+7 lines, -6 lines	0 comments	Download
M	webkit/glue/devtools/debugger_agent_impl.cc	View	1	4 chunks	+14 lines, -13 lines	0 comments	Download
M	webkit/glue/devtools/js/devtools.js	View	2	2 chunks	+1 line, -1 line	0 comments	Download
M	webkit/glue/devtools/js/inject.js	View	1 2	1 chunk	+294 lines, -285 lines	0 comments	Download
M	webkit/glue/devtools/js/inject_dispatch.js	View		1 chunk	+33 lines, -33 lines	0 comments	Download
M	webkit/glue/webdevtoolsagent_impl.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webdevtoolsagent_impl.cc	View	1	4 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

LGTM if the commments are addressed http://codereview.chromium.org/100159/diff/1/4 File webkit/glue/devtools/debugger_agent_impl.cc (right): http://codereview.chromium.org/100159/diff/1/4#newcode68 Line 68: context->Dispose(); it ...

11 years, 7 months ago (2009-04-29 14:07:14 UTC) #2

pfeldman

11 years, 7 months ago (2009-04-29 14:34:13 UTC) #3

http://codereview.chromium.org/100159/diff/1/4
File webkit/glue/devtools/debugger_agent_impl.cc (right):

http://codereview.chromium.org/100159/diff/1/4#newcode68
Line 68: context->Dispose();
On 2009/04/29 14:07:14, Yury Semikhatsky wrote:
> it seems that the context may leak on webdevtoolsagent destruction so please
> make sure that Dispose is called from the destructor

Done.

Expand Messages | Collapse Messages

Issue 100159: DevTools: keep links on the edited styles so that they are not collected betw... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages