Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 100158: Create a transition API for the debug message handler (Closed)

Created:
11 years, 7 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Create a transition API for the debug message handler. Kept the previous message handler API to avoid breaking clients depending on it. The new message handler API uses a new name ending with 2. Committed: http://code.google.com/p/v8/source/detail?r=1816

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -17 lines) Patch
M include/v8-debug.h View 2 chunks +16 lines, -2 lines 2 comments Download
M src/api.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M src/debug.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug-agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 8 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Thygesen Gjesse
This is a temporary solution to avoid breaking current clients and keep the new debugger ...
11 years, 7 months ago (2009-04-29 12:17:46 UTC) #1
yurys
http://codereview.chromium.org/100158/diff/1/3 File include/v8-debug.h (right): http://codereview.chromium.org/100158/diff/1/3#newcode205 Line 205: static void SetMessageHandler2(MessageHandler2 handler); When all clients are ...
11 years, 7 months ago (2009-04-29 12:36:08 UTC) #2
Mads Ager (chromium)
LGTM This is rather heavy though as Yury points out. However, we do need to ...
11 years, 7 months ago (2009-04-29 12:49:30 UTC) #3
Søren Thygesen Gjesse
11 years, 7 months ago (2009-04-29 13:24:15 UTC) #4
http://codereview.chromium.org/100158/diff/1/3
File include/v8-debug.h (right):

http://codereview.chromium.org/100158/diff/1/3#newcode205
Line 205: static void SetMessageHandler2(MessageHandler2 handler);
On 2009/04/29 12:36:08, Yury Semikhatsky wrote:
> When all clients are switched to the new message handler we will need to
remove
> the old one and rename SetMessageHandler2 to SetMessageHandler which will
break
> the code anyway. Consider switching to the new API without this intermediate
> step.

I agree that this is not optimal, but we need to keep the Webkit (V8-Latest)
builder happy so that we can catch any regressions before pushing to trunk. This
API incompatibility is actually such a regression.

When we push to trunk with the rename from MessageHandler2 -> MessageHandler the
DEPS roll and the client changes in Chromium can be done as a single commit.

Powered by Google App Engine
This is Rietveld 408576698