Issue 100146: Changes in preparation for webkit switch to gyp....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100146: Changes in preparation for webkit switch to gyp.... (Closed)

Created:
11 years, 7 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Changes in preparation for webkit switch to gyp. These won't get gated live without a change to all.gyp, so landing them separately. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14822

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
M	chrome/tools/build/win/language_dll.vsprops	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/grit/build/using_generated_resources.vsprops	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell.gyp	View		3 chunks	+10 lines, -2 lines	0 comments	Download
M	webkit/webkit.gyp	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sgk

11 years, 7 months ago (2009-04-29 03:36:47 UTC) #3

http://codereview.chromium.org/100146/diff/1005/1006
File webkit/webkit.gyp (right):

http://codereview.chromium.org/100146/diff/1005/1006#newcode4574
Line 4574: 'pending/AccessibleDocument.cpp',
These went away in a previous CL.  Remove these lines, and there should be no
need for webkit.gyp in this CL.

Expand Messages | Collapse Messages