Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 100144: Move simple_clipboard_impl.cc to webkit/tools/test_shell where it belongs. (Closed)

Created:
11 years, 7 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Move simple_clipboard_impl.cc to webkit/tools/test_shell where it belongs.

Patch Set 1 #

Patch Set 2 : vcproj #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -70 lines) Patch
M webkit/glue/simple_clipboard_impl.cc View 1 chunk +0 lines, -56 lines 0 comments Download
A webkit/tools/test_shell/simple_clipboard_impl.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gyp View 1 3 chunks +1 line, -8 lines 0 comments Download
M webkit/tools/test_shell/test_shell.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_tests.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_worker/test_worker.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M webkit/webkit.gyp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tony
FYI: This may make the transition easier tonight. If you don't need it for the ...
11 years, 7 months ago (2009-04-29 00:31:01 UTC) #1
bradn
LGTM, but yeah wait until after the transition.
11 years, 7 months ago (2009-04-29 00:44:07 UTC) #2
tony
Can I check this in today or should I wait until tomorrow?
11 years, 7 months ago (2009-04-29 18:11:52 UTC) #3
tony
The current patch set includes the vcproj changes. It passes on my local windows box.
11 years, 7 months ago (2009-04-29 22:02:28 UTC) #4
bradn
11 years, 7 months ago (2009-04-29 22:25:37 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698