Switch to a raw kAEOpenDocuments AppleEvent handler for opening dropped files...

Switch to a raw kAEOpenDocuments AppleEvent handler for opening dropped files to avoid crashes when Cocoa feeds us files specified on the command line.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14876

[Avi (use Gerrit), 2009-04-29 00:21:23]

This is the fix as we discussed.

[pink (ping after 24hrs), 2009-04-29 13:05:49]

LGTM

http://codereview.chromium.org/100142/diff/1/2
File chrome/browser/app_controller_mac.mm (right):

http://codereview.chromium.org/100142/diff/1/2#newcode219
Line 219: GURL gurl(std::string((char*)[fileURLData bytes], [fileURLData
length]));
is there any chance fileURLData could be nil or have nil bytes? Should we be
defensive?

[Avi (use Gerrit), 2009-04-29 18:44:11]

http://codereview.chromium.org/100142/diff/1/2
File chrome/browser/app_controller_mac.mm (right):

http://codereview.chromium.org/100142/diff/1/2#newcode219
Line 219: GURL gurl(std::string((char*)[fileURLData bytes], [fileURLData
length]));
On 2009/04/29 13:05:49, pink wrote:
> is there any chance fileURLData could be nil or have nil bytes? Should we be
> defensive?

I'll sprinkle some nil checking around (take a look now), but nil bytes is
something that I have to assume won't be there, that the url I get is
well-formatted.

[pink (ping after 24hrs), 2009-04-29 19:34:49]

still LGTM