Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: content/public/browser/web_contents_delegate.h

Issue 10014013: Add a hang monitor for Pepper plugins (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_delegate.h
diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h
index 49e833ddd3c5fa976753d793d3f6b46e71de2bac..d2ed542f78dea97169153b660cef59e87c04182e 100644
--- a/content/public/browser/web_contents_delegate.h
+++ b/content/public/browser/web_contents_delegate.h
@@ -372,6 +372,19 @@ class CONTENT_EXPORT WebContentsDelegate {
// Notification that a plugin has crashed.
virtual void CrashedPlugin(WebContents* tab, const FilePath& plugin_path) {}
+ // Notication that the given plugin has hung or become unhung. This
+ // notification is only for Pepper plugins.
+ //
+ // The plugin_child_id is the unique child process ID from the plugin. Note
+ // that this ID is supplied by the renderer, so should be validated before
+ // it's used for anything in case there's an exploited renderer. The name
+ // will be provided if it is available, otherwise name will be empty and the
+ // implementation should use the path to extract the plugin name.
+ virtual void PluginHungStatusChanged(WebContents* tab,
+ int plugin_child_id,
+ const FilePath& plugin_path,
+ bool is_hung) {}
+
// Invoked when the preferred size of the contents has been changed.
virtual void UpdatePreferredSize(WebContents* tab,
const gfx::Size& pref_size) {}

Powered by Google App Engine
This is Rietveld 408576698