Add a hang monitor for Pepper plugins

content/public/browser/web_contents_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 #pragma once
 
 #include <set>
 #include <string>
@@ skipping 354 matching lines @@
   virtual void FindReply(WebContents* tab,
                          int request_id,
                          int number_of_matches,
                          const gfx::Rect& selection_rect,
                          int active_match_ordinal,
                          bool final_update) {}
 
   // Notification that a plugin has crashed.
   virtual void CrashedPlugin(WebContents* tab, const FilePath& plugin_path) {}
 
+  // Notication that the given plugin has hung or become unhung. This
+  // notification is only for Pepper plugins.
+  //
+  // The child_id is the unique child process ID from the plugin. Note that this

[yzshen1, 2012/04/11 18:30:46]

nit: child_id -> plugin_child_id.

+  // ID is supplied by the renderer, so should be validated before it's used
+  // for anything in case there's an exploited renderer. The name will be

[yzshen1, 2012/04/11 18:30:46]

"name" is not presented as a parameter?

[yzshen1, 2012/04/11 20:08:10]

This is not addressed. (Have I misunderstood it?)

[brettw, 2012/04/11 20:30:25]

Sorry! This was from a previous version of the patch but I never ended up using
the name so I removed it.

+  // provided if it is available, otherwise name will be empty and the
+  // implementation should use the patch to extract the plugin name.

[yzshen1, 2012/04/11 18:30:46]

patch -> path.

+  virtual void PluginHungStatusChanged(WebContents* tab,
+                                       int plugin_child_id,
+                                       const FilePath& plugin_path,
+                                       bool is_hung) {}
+
   // Invoked when the preferred size of the contents has been changed.
   virtual void UpdatePreferredSize(WebContents* tab,
                                    const gfx::Size& pref_size) {}
 
   // Invoked when the contents auto-resized and the container should match it.
   virtual void ResizeDueToAutoResize(WebContents* tab,
                                      const gfx::Size& new_size) {}
 
   // Notification message from HTML UI.
   virtual void WebUISend(WebContents* tab,
@@ skipping 21 matching lines @@
   // Called when |this| is no longer the WebContentsDelegate for |source|.
   void Detach(WebContents* source);
 
   // The WebContents that this is currently a delegate for.
   std::set<WebContents*> attached_contents_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_