Issue 100132: Instead of passing down a switch to the renderer, storing a member, etc., jus...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100132: Instead of passing down a switch to the renderer, storing a member, etc., jus... (Closed)

Created:
11 years, 8 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Instead of passing down a switch to the renderer, storing a member, etc., just implement --disable-popup-blocking in the browser at the point where we make the final policy decision. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14851

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -25 lines)			Patch
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/renderer/render_view.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	4 chunks	+2 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

11 years, 7 months ago (2009-04-28 22:28:12 UTC) #2

LGTM.

I want to say that Patrick had a reason for implementing things this way, but if
this doesn't regress anything, this is a bit cleaner...

Expand Messages | Collapse Messages