Issue 100131: Finished implementing seeking in WebMediaPlayerDelegateImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100131: Finished implementing seeking in WebMediaPlayerDelegateImpl. (Closed)

Created:
11 years, 7 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Finished implementing seeking in WebMediaPlayerDelegateImpl. Turns out we need to add a few more things to the Pipeline interface for time update/seek completion callbacks, but for now this works pretty well.

Patch Set 1 #

Patch Set 2 : Typo #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -4 lines)			Patch
M	chrome/renderer/media/data_source_impl.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/webmediaplayer_delegate_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/webmediaplayer_delegate_impl.cc	View	1	3 chunks	+16 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages