Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 100124: Implement a couple more methods for dialog boxes. (Closed)

Created:
11 years, 8 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Implement a couple more methods for dialog boxes including the prompt box. BUG=9623

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 6

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M chrome/browser/app_modal_dialog_gtk.cc View 1 2 4 chunks +26 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tony
11 years, 8 months ago (2009-04-28 21:43:18 UTC) #1
Evan Martin
http://codereview.chromium.org/100124/diff/4/5 File chrome/browser/app_modal_dialog_gtk.cc (right): http://codereview.chromium.org/100124/diff/4/5#newcode20 Line 20: // return it. This feels fragile. Is there ...
11 years, 8 months ago (2009-04-28 21:56:59 UTC) #2
tony
http://codereview.chromium.org/100124/diff/4/5 File chrome/browser/app_modal_dialog_gtk.cc (right): http://codereview.chromium.org/100124/diff/4/5#newcode20 Line 20: // return it. On 2009/04/28 21:56:59, Evan Martin ...
11 years, 8 months ago (2009-04-28 22:05:46 UTC) #3
Evan Martin
11 years, 8 months ago (2009-04-28 22:10:58 UTC) #4
ship it

Powered by Google App Engine
This is Rietveld 408576698