Add a few extra error messages to help catch typos in schemas.

Add a few extra error messages to help catch typos in schemas.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14850

[Aaron Boodman, 2009-04-28 20:21:31]

lgtm, whatever you decide on comment below.

http://codereview.chromium.org/100113/diff/1/2
File chrome/renderer/resources/json_schema.js (right):

http://codereview.chromium.org/100113/diff/1/2#newcode220
Line 220: this.addError(propPath, "invalidPropertyType");
This branch will get entered when schema.properties[prop] is defined, but
contains any falsy value like: false, 0, undefined, or null. Is that what you
intended? I guess I'm not sure what this is trying to test.

[Erik does not do reviews, 2009-04-28 20:29:34]

http://codereview.chromium.org/100113/diff/1/2
File chrome/renderer/resources/json_schema.js (right):

http://codereview.chromium.org/100113/diff/1/2#newcode220
Line 220: this.addError(propPath, "invalidPropertyType");
On 2009/04/28 20:21:31, Aaron Boodman wrote:
> This branch will get entered when schema.properties[prop] is defined, but
> contains any falsy value like: false, 0, undefined, or null. Is that what you
> intended? I guess I'm not sure what this is trying to test.

No.  I'm looking for undefined.  The problem I'm testing for is when in the
schema you have something like this:
properties: {
  title: chromium.types.string
}

instead of

properties: {
  title: chromium.types.str
}

So I'll change to test specifically against undefined.