Fullscreen mode for Linux.

Basic fullscreen mode for Linux, without the animated exit bubble.

Parts of the code are from ermilov.maxim@gmail.com. Thanks!

BUG=8405
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14912

[James Hawkins, 2009-04-28 16:09:22]

lgtm with comments.

http://codereview.chromium.org/100106/diff/1/4
File chrome/browser/gtk/browser_window_gtk.h (right):

http://codereview.chromium.org/100106/diff/1/4#newcode153
Line 153: // Where we are full screen.
'Where'?  That doesn't make sense.

http://codereview.chromium.org/100106/diff/1/4#newcode154
Line 154: // Don't rely on |state_| & GDK_WINDOW_STATE_FULLSCREEN
Can you more comment explaining why we can't rely on that?

[Lei Zhang, 2009-04-28 16:41:11]

http://codereview.chromium.org/100106/diff/1/4
File chrome/browser/gtk/browser_window_gtk.h (right):

http://codereview.chromium.org/100106/diff/1/4#newcode153
Line 153: // Where we are full screen.
On 2009/04/28 16:09:22, James Hawkins wrote:
> 'Where'?  That doesn't make sense.

Vim Ctrl + N/P fail. I was trying to autocomplete "Whether"

http://codereview.chromium.org/100106/diff/1/4#newcode154
Line 154: // Don't rely on |state_| & GDK_WINDOW_STATE_FULLSCREEN
On 2009/04/28 16:09:22, James Hawkins wrote:
> Can you more comment explaining why we can't rely on that?

Sure. See next patchset.

[Evan Martin, 2009-04-28 16:43:10]

Isn't there some other flag set used to track full screen?  Let me confirm
before you LGTM

[Evan Martin, 2009-04-28 16:44:33]

Never mind, I was thinkin of WindowFeature in the Browser class .