Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 100104: Added better version information (Closed)

Created:
11 years, 8 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added better version information The current version is now held in src/version.cc in a number of defines which needs to be modified when changing version. The following defines make up the version information: MAJOR_VERSION MINOR_VERSION BUILD_NUMBER PATCH_LEVEL CANDIDATE_VERSION The first four are numbers and the fifth is a boolean. Besides these five the define SONAME can be used to set a specific soname when building the a shared library (see below). This will most likely be used on stable branches where binary compatibility is ensured between different versions. This define is a string. This version information is now read by the SCons build to support setting the soname for a Linux shared library. This requires passing the option soname=on to the SCons build. When soname=on is specified the soname for the shared library can be set in two different ways. Either it will be the full versioned library name (e.g. libv8-1.2.2.so) or a specific soname defined in src/version.cc. Whenever a shared library is build with an soname the filename of the library will hold the full version name (e.g. libv8-1.2.2.so). I did not update the xcode project with the new files. BUG=151 Committed: http://code.google.com/p/v8/source/detail?r=1826

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -4 lines) Patch
M SConstruct View 1 2 3 4 5 chunks +70 lines, -1 line 0 comments Download
M src/SConscript View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/api.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
A src/version.h View 1 2 3 4 1 chunk +63 lines, -0 lines 0 comments Download
A src/version.cc View 1 2 3 4 1 chunk +89 lines, -0 lines 0 comments Download
M test/cctest/SConscript View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A test/cctest/test-version.cc View 1 2 3 4 1 chunk +88 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base.vcproj View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base_arm.vcproj View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_cctest.vcproj View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_cctest_arm.vcproj View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Søren Thygesen Gjesse
11 years, 8 months ago (2009-04-28 14:33:57 UTC) #1
Mads Ager (chromium)
LGTM for the code part. I don't know enough about the expectations for the soname ...
11 years, 7 months ago (2009-04-29 06:02:54 UTC) #2
Søren Thygesen Gjesse
http://codereview.chromium.org/100104/diff/1013/1025 File SConstruct (right): http://codereview.chromium.org/100104/diff/1013/1025#newcode231 Line 231: }, On 2009/04/29 06:02:54, Mads Ager wrote: > ...
11 years, 7 months ago (2009-04-29 19:52:46 UTC) #3
Søren Thygesen Gjesse
Changes the naming scheme slightly to match my suggestion written as comment #4 on issue ...
11 years, 7 months ago (2009-04-29 20:01:46 UTC) #4
Mads Ager (chromium)
LGTM
11 years, 7 months ago (2009-04-30 06:36:57 UTC) #5
Christian Plesner Hansen
Lgtm!
11 years, 7 months ago (2009-04-30 07:36:14 UTC) #6
Søren Thygesen Gjesse
One (final?) update where I have added the option of setting a specific soname. Please ...
11 years, 7 months ago (2009-04-30 08:38:03 UTC) #7
Mads Ager (chromium)
11 years, 7 months ago (2009-04-30 08:56:31 UTC) #8
Still LGTM.

Powered by Google App Engine
This is Rietveld 408576698