Issue 100102: Rename profileview.js -> profile_view.js because WebInspector already has ProfileView.js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100102: Rename profileview.js -> profile_view.js because WebInspector already has ProfileView.js. (Closed)

Created:
11 years, 8 months ago by Mikhail Naganov

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Rename profileview.js -> profile_view.js because WebInspector already has ProfileView.js. Committed: http://code.google.com/p/v8/source/detail?r=1805

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+282 lines, -282 lines)			Patch
A	test/mjsunit/tools/profile_view.js	View	1 chunk	+95 lines, -0 lines	0 comments	Download
M	test/mjsunit/tools/profileview.js	View	1 chunk	+0 lines, -95 lines	0 comments	Download
M	tools/linux-tick-processor	View	1 chunk	+1 line, -1 line	0 comments	Download
A	tools/profile_view.js	View	1 chunk	+185 lines, -0 lines	0 comments	Download
M	tools/profileview.js	View	1 chunk	+0 lines, -185 lines	0 comments	Download
M	tools/windows-tick-processor.bat	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM Did you use svn move? From the Rietveld info it does not look as ...

11 years, 8 months ago (2009-04-28 09:12:42 UTC) #2

Mikhail Naganov

11 years, 8 months ago (2009-04-28 09:19:50 UTC) #3

On 2009/04/28 09:12:42, Søren Gjesse wrote:
> LGTM
> 
> Did you use svn move? From the Rietveld info it does not look as if you did
not.
> Normally the new file will show where it was moved from. Of cause the history
> for these files are not important at the moment, so it is not an issue here
now.

Hmm... Looks like git-cl doesn't report file moves properly to svn.

Expand Messages | Collapse Messages