Do not show the install prompt for themes.

chrome/browser/extensions/extension_install_ui.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_UI_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_UI_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/string16.h"
 #include "chrome/browser/extensions/image_loading_tracker.h"
 #include "chrome/common/extensions/url_pattern.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/native_widget_types.h"
 
 class Browser;
 class Extension;
 class ExtensionPermissionSet;
 class MessageLoop;
 class Profile;
 class InfoBarDelegate;
 class TabContentsWrapper;
 
+namespace base {
+class DictionaryValue;
+}  // namespace base
+
 namespace extensions {
 class BundleInstaller;
 }  // namespace extensions
 
 // Displays all the UI around extension installation.
 class ExtensionInstallUI : public ImageLoadingTracker::Observer {
  public:
   enum PromptType {
     UNSET_PROMPT_TYPE = -1,
     INSTALL_PROMPT = 0,
@@ skipping 86 matching lines @@
     virtual void InstallUIProceed() = 0;
 
     // We call this method to signal that the installation should stop, with
     // |user_initiated| true if the installation was stopped by the user.
     virtual void InstallUIAbort(bool user_initiated) = 0;
 
    protected:
     virtual ~Delegate() {}
   };
 
+  // Creates a dummy extension from the |manifest|, replacing the name and
+  // description with the localizations if provided.
+  static scoped_refptr<Extension> LocalizeExtensionForDisplay(

[Yoyo Zhou, 2012/04/20 15:38:14]

I think GetLocalizedExtensionForDisplay would be clearer.

[jstritar, 2012/04/20 16:18:27]

Done.

+      const base::DictionaryValue* manifest,
+      const std::string& id,
+      const std::string& localized_name,
+      const std::string& localized_description,
+      std::string* error);
+
   explicit ExtensionInstallUI(Profile* profile);
   virtual ~ExtensionInstallUI();
 
   // TODO(asargent) Normally we navigate to the new tab page when an app is
   // installed, but we're experimenting with instead showing a bubble when
   // an app is installed which points to the new tab button. This may become
   // the default behavior in the future.
   void set_use_app_installed_bubble(bool use_bubble) {
     use_app_installed_bubble_ = use_bubble;
   }
 
   // Whether or not to show the default UI after completing the installation.
   void set_skip_post_install_ui(bool skip_ui) {
     skip_post_install_ui_ = skip_ui;
   }
 
+  // This is called by the bundle installer to verify whether the bundle
+  // should be installed.
+  //
+  // We *MUST* eventually call either Proceed() or Abort() on |delegate|.
+  virtual void ConfirmBundleInstall(extensions::BundleInstaller* bundle,
+                                    const ExtensionPermissionSet* permissions);
+
+  // This is called by the inline installer to verify whether the inline
+  // install from the webstore should proceed.
+  //
+  // We *MUST* eventually call either Proceed() or Abort() on |delegate|.
+  virtual void ConfirmInlineInstall(Delegate* delegate,
+                                    const Extension* extension,
+                                    SkBitmap* icon,
+                                    Prompt prompt);
+
+  // This is called by the installer to verify whether the installation from
+  // the webstore should proceed.
+  //
+  // We *MUST* eventually call either Proceed() or Abort() on |delegate|.
+  virtual void ConfirmWebstoreInstall(Delegate* delegate,
+                                      const Extension* extension,
+                                      const SkBitmap* icon);
+
   // This is called by the installer to verify whether the installation should
   // proceed. This is declared virtual for testing.
   //
   // We *MUST* eventually call either Proceed() or Abort() on |delegate|.
   virtual void ConfirmInstall(Delegate* delegate, const Extension* extension);
 
   // This is called by the app handler launcher to verify whether the app
   // should be re-enabled. This is declared virtual for testing.
   //
   // We *MUST* eventually call either Proceed() or Abort() on |delegate|.
@@ skipping 41 matching lines @@
 
   // Sets the icon that will be used in any UI. If |icon| is NULL, or contains
   // an empty bitmap, then a default icon will be used instead.
   void SetIcon(const SkBitmap* icon);
 
   // Starts the process of showing a confirmation UI, which is split into two.
   // 1) Set off a 'load icon' task.
   // 2) Handle the load icon response and show the UI (OnImageLoaded).
   void ShowConfirmation(PromptType prompt_type);
 
+  // Shows the actual UI (the icon should already be loaded).
+  void ShowDialog();
+
   // Returns the delegate to control the browser's info bar. This is
   // within its own function due to its platform-specific nature.
   static InfoBarDelegate* GetNewThemeInstalledInfoBarDelegate(
       TabContentsWrapper* tab_contents,
       const Extension* new_theme,
       const std::string& previous_theme_id,
       bool previous_using_native_theme);
 
   Profile* profile_;
   MessageLoop* ui_loop_;
 
   // Used to undo theme installation.
   std::string previous_theme_id_;
   bool previous_using_native_theme_;
 
   // The extensions installation icon.
   SkBitmap icon_;
 
   // The extension we are showing the UI for.
   const Extension* extension_;
 
+  // The bundle we are showing the UI for, if type BUNDLE_INSTALL_PROMPT.
+  const extensions::BundleInstaller* bundle_;
+
   // The permissions being prompted for.
   scoped_refptr<const ExtensionPermissionSet> permissions_;
 
   // The delegate we will call Proceed/Abort on after confirmation UI.
   Delegate* delegate_;
 
+  // A pre-filled prompt.
+  Prompt prompt_;

[Yoyo Zhou, 2012/04/20 15:38:14]

It seems like if this is sometimes present and sometimes not, it'd be better to
used a pointer type, so you don't need to initialize it in the case that it's
not given.

[jstritar, 2012/04/20 16:18:27]

I'd rather avoid managing the Prompt's life-cycle. I added a set_type method to
the Prompt, so we don't need to recreate it. How does that look?

[Yoyo Zhou, 2012/04/20 17:19:12]

Seems fine to me -- I mean, we were copying Prompts before, so it's (presumably)
not a big deal. Not having to check for the UNSET_PROMPT_TYPE seems to be an
improvement, though.

+
   // The type of prompt we are going to show.
   PromptType prompt_type_;
 
   // Keeps track of extension images being loaded on the File thread for the
   // purpose of showing the install UI.
   ImageLoadingTracker tracker_;
 
   // Whether to show an installed bubble on app install, or use the default
   // action of opening a new tab page.
   bool use_app_installed_bubble_;
 
   // Whether or not to show the default UI after completing the installation.
   bool skip_post_install_ui_;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_UI_H_