Allow dynamic switching in and out of sidetabs mode.

Allow dynamic switching in and out of sidetabs mode.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42156

[sky, 2010-03-19 16:13:59]

LGTM

http://codereview.chromium.org/1001003/diff/21001/22024
File chrome/browser/tabs/tab_strip_model.cc (right):

http://codereview.chromium.org/1001003/diff/21001/22024#newcode588
chrome/browser/tabs/tab_strip_model.cc:588: ContextMenuCommand command_id) const
{
nit: > 80

http://codereview.chromium.org/1001003/diff/21001/22015
File chrome/browser/views/frame/browser_frame_win.cc (right):

http://codereview.chromium.org/1001003/diff/21001/22015#newcode128
chrome/browser/views/frame/browser_frame_win.cc:128: GetRootView()->Layout();
Why do you need to layout twice? If you really do, could you add a comment as to
why.

http://codereview.chromium.org/1001003/diff/21001/22006
File chrome/browser/views/tabs/browser_tab_strip_controller.h (right):

http://codereview.chromium.org/1001003/diff/21001/22006#newcode62
chrome/browser/views/tabs/browser_tab_strip_controller.h:62: class
TabContextMenuContents;
move class definition before all fields.

http://codereview.chromium.org/1001003/diff/21001/22010
File chrome/browser/views/tabs/tab_strip.cc (right):

http://codereview.chromium.org/1001003/diff/21001/22010#newcode1281
chrome/browser/views/tabs/tab_strip.cc:1281: // TODO(beng): This "closing" state
should be stored in the model.
You sure? It's only the ui that knows about it. It would complicate the model to
hold onto the tab for a while after it's been deleted.