Issue 100095: Convert gcl.GetSVNFileInfo() to xml format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100095: Convert gcl.GetSVNFileInfo() to xml format. (Closed)

Created:
11 years, 8 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Convert gcl.GetSVNFileInfo() to xml format. Add gcl's first unit test. Add version string. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14771

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+282 lines, -38 lines)			Patch
M	gcl.py	View	1 2	7 chunks	+120 lines, -37 lines	0 comments	Download
M	revert.py	View	2	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/gcl_unittest.py	View	1	1 chunk	+161 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

11 years, 8 months ago (2009-04-28 18:35:20 UTC) #2

lgtm

http://codereview.chromium.org/100095/diff/1001/1002
File gcl.py (right):

http://codereview.chromium.org/100095/diff/1001/1002#newcode158
Line 158: statuses[0] = 'C'
do we care about ignored or replaced?  sometimes i'd see them.

Expand Messages | Collapse Messages