Issue 100086: Enabling the user install tests to see if they pass. They were failing becaus...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100086: Enabling the user install tests to see if they pass. They were failing becaus... (Closed)

Created:
11 years, 8 months ago by anantha

Modified:
9 years, 6 months ago

Reviewers:
kuchhal

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enabling the user install tests to see if they pass. They were failing because of two reasons: 1. the new profile dialog closes the setup.exe process as soon as the dialog is closed. The testcase used to wait for setup.exe to start/end, which would never happen. heence the test failed. 2. Closing of new profile dialog also deletes the reg keys right away. looks like there were some timing issues.Added a sleep of 400 to see if the test passes now. if it passes, then I will look into other options and remove the sleep. ----- The standalone installer path got changed recently. modified that path also. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14693

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -4 lines)			Patch
M	chrome/test/mini_installer_test/chrome_mini_installer.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/test/mini_installer_test/mini_installer_test_constants.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/mini_installer_test/test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages