Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 100085: Adds a second vector of streams to FFmpegDemuxer to handle re-mapped audio/video streams. (Closed)

Created:
11 years, 8 months ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
Reviewers:
ralphl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Adds a second vector of streams to FFmpegDemuxer to handle re-mapped audio/video streams. For media containing non-audio/video streams we were properly exposing the correct streams via Demuxer::GetStream() (i.e., no data streams were exposed) however we weren't properly re-routing the packets to the correct streams during demuxing. Before: Media contains [DATA, AUDIO, VIDEO] We create supported vector [AUDIO, VIDEO] When demuxing a packet who says they are from stream 1 (AUDIO), we would incorrectly assign it to VIDEO After: Media contains [DATA, AUDIO, VIDEO] We create supported vector [AUDIO, VIDEO] We create extra packet vector [NULL, AUDIO, VIDEO] When demuxing, we now correctly assign it to the proper stream and automatically free unused packets

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -22 lines) Patch
M media/filters/ffmpeg_demuxer.h View 1 chunk +9 lines, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 6 chunks +32 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
11 years, 8 months ago (2009-04-28 00:21:38 UTC) #1
ralphl
11 years, 8 months ago (2009-04-28 16:42:14 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698