Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 10008105: Remove dependency from InputMethodUtil to InputMethodManager. (Closed)

Created:
8 years, 8 months ago by Yusuke Sato
Modified:
8 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Remove dependency from InputMethodUtil to InputMethodManager. Looks like the dependency is accidentially introduced by http://src.chromium.org/viewvc/chrome?view=rev&revision=131801. BUG=None TEST=ran unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/browser/chromeos/input_method/input_method_util.cc View 3 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yusuke Sato
8 years, 8 months ago (2012-04-13 08:06:32 UTC) #1
yoshiki
LGTM
8 years, 8 months ago (2012-04-13 08:07:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10008105/1
8 years, 8 months ago (2012-04-13 08:37:21 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 10:59:44 UTC) #4
Change committed as 132171

Powered by Google App Engine
This is Rietveld 408576698