Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 10008081: Show actual results for accessibility dump render tree tests as well. Showing a * in front of incor… (Closed)

Created:
8 years, 8 months ago by aaronlevbugs
Modified:
8 years, 8 months ago
CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Show actual results for accessibility dump render tree tests as well. Showing a * in front of incorrect expected lines is not enough. We need to see what the actual results were as well. BUG=120934 TEST=This is a fix for tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
aaronlevbugs
Ready for review. Fixes an oversight in the recent update to the dump render tree ...
8 years, 8 months ago (2012-04-12 16:47:27 UTC) #1
dmazzoni
lgtm Thanks
8 years, 8 months ago (2012-04-12 16:55:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aaronlevbugs@gmail.com/10008081/1
8 years, 8 months ago (2012-04-12 16:55:36 UTC) #3
commit-bot: I haz the power
Try job failure for 10008081-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-12 19:57:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aaronlevbugs@gmail.com/10008081/1
8 years, 8 months ago (2012-04-12 20:48:06 UTC) #5
commit-bot: I haz the power
Try job failure for 10008081-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-12 23:57:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aaronlevbugs@gmail.com/10008081/1
8 years, 8 months ago (2012-04-13 20:29:13 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 21:48:57 UTC) #8
Change committed as 132277

Powered by Google App Engine
This is Rietveld 408576698