Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 10008079: [cros] Use system request context for OAuth1 access token verification (Closed)

Created:
8 years, 8 months ago by Nikita (slow)
Modified:
8 years, 8 months ago
Reviewers:
zel, Ivan Korotkov
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[cros] Use system request context for OAuth1 access token verification. Also retry if OAuth fetcher is cancelled during verification. BUG=122972 TEST=Manual. Sign with SPDY proxy enabled. Sign out. Notice that OAuth token is valid i.e. you're not asked for OTP. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132222

Patch Set 1 #

Patch Set 2 : use system request context #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome/browser/chromeos/login/login_utils.cc View 1 2 chunks +7 lines, -8 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
Nikita (slow)
Tested, please take a look. We might want to merge it into M19. GoogleServiceAuthError::REQUEST_CANCELED was ...
8 years, 8 months ago (2012-04-12 17:58:39 UTC) #1
Nikita (slow)
8 years, 8 months ago (2012-04-13 12:32:22 UTC) #2
Ivan Korotkov
lgtm
8 years, 8 months ago (2012-04-13 12:42:21 UTC) #3
Nikita (slow)
http://codereview.chromium.org/10008079/diff/2001/chrome/browser/chromeos/login/login_utils.cc File chrome/browser/chromeos/login/login_utils.cc (left): http://codereview.chromium.org/10008079/diff/2001/chrome/browser/chromeos/login/login_utils.cc#oldcode205 chrome/browser/chromeos/login/login_utils.cc:205: user_profile->GetOffTheRecordProfile()->GetRequestContext(), Zel, what was the reason why we initially ...
8 years, 8 months ago (2012-04-13 12:45:55 UTC) #4
zel
lgtm
8 years, 8 months ago (2012-04-13 17:08:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/10008079/2001
8 years, 8 months ago (2012-04-13 17:11:02 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 18:39:12 UTC) #7
Change committed as 132222

Powered by Google App Engine
This is Rietveld 408576698