Add onFontNameChanged event to Font Settings API

chrome/common/extensions/api/experimental.fontSettings.json

Index: chrome/common/extensions/api/experimental.fontSettings.json
diff --git a/chrome/common/extensions/api/experimental.fontSettings.json b/chrome/common/extensions/api/experimental.fontSettings.json
index 800d758ca9419fe851143d86a29a0314f4a283ed..bbafb10d16b688f75f75ea35c3628be071ecec95 100644
--- a/chrome/common/extensions/api/experimental.fontSettings.json
+++ b/chrome/common/extensions/api/experimental.fontSettings.json
@@ -285,6 +285,43 @@
           }
         ]
       }
+    ],
+    "events": [
+      {
+        "name": "onFontNameChanged",

[Matt Perry, 2012/04/12 20:31:44]

The name of this event is confusing to me. It sounds like the name of the font
has changed. Would something like onFontSettingChanged make more sense? I
realize it wouldn't parallel get/setFontName, unfortunately...

[falken, 2012/04/13 10:33:46]

What do you think of changing get/setFontName to just get/setFont? Then the
event can be onFontChanged. I wanted them to be parallel since I plan to add
onDefaultFontSizeChanged, etc, as well.

If that's OK, I'd like to make that change in a second patch, since this one is
getting rather big and it would require changing the example extension as well.

[Matt Perry, 2012/04/13 18:15:45]

Perfect, SGTM

+        "type": "function",

[Bernhard Bauer, 2012/04/12 13:14:01]

The "type" attribute is unnecessary for events, and it's not a function in this
case :) (it's also unnecessary for API methods above; you only need it for
parameter lists or attributes of classes like ChromeSetting)

[falken, 2012/04/13 10:33:46]

Done.

+        "description": "Fired when a font name preference changes.",
+        "parameters": [
+          {
+            "type": "object",
+            "name": "details",
+            "properties": {
+              "fontName": { "type": "string" },
+              "script": {
+                "type": "string",
+                "enum": [

[Bernhard Bauer, 2012/04/12 13:14:01]

You could pull out this enum into a separate type, so you don't have to copy the
definition everywhere.

[falken, 2012/04/13 10:33:46]

Done, and also moved genericFamily to a new type.

+                    "Arab", "Armn", "Beng", "Cans", "Cher", "Cyrl", "Deva", "Ethi", "Geor",
+                    "Grek", "Gujr", "Guru", "Hang", "Hans", "Hant", "Hebr", "Hrkt", "Knda",
+                    "Khmr", "Laoo", "Mlym", "Mong", "Mymr", "Orya", "Sinh", "Taml", "Telu",
+                    "Thaa", "Thai", "Tibt", "Yiii"
+                ],
+                "description": "The ISO 15924 script code for which the font setting has changed. If omitted, the global script font setting has changed.",
+                "optional": true
+              },
+              "genericFamily": {
+                "type": "string",
+                "enum": ["standard", "sansserif", "serif", "fixed", "cursive", "fantasy"],
+                "description": "The CSS generic font family for which the font setting has changed."
+              },
+              "levelOfControl": {
+                "description": "One of<br><var>not_controllable</var>: cannot be controlled by any extension<br><var>controlled_by_other_extensions</var>: controlled by extensions with higher precedence<br><var>controllable_by_this_extension</var>: can be controlled by this extension<br><var>controlled_by_this_extension</var>: controlled by this extension",
+                "type": "string",
+                "enum": ["not_controllable", "controlled_by_other_extensions", "controllable_by_this_extension", "controlled_by_this_extension"]
+              }
+            }
+          }
+        ]
+      }
     ]
   }
 ]