Issue 10008061: Rename intermediate dlldata.c file to make names non-conflicting (for ninja/windows)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10008061: Rename intermediate dlldata.c file to make names non-conflicting (for ninja/windows) (Closed)

Created:
8 years, 8 months ago by scottmg

Modified:
8 years, 8 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

These targets were causing files to have the same output target, which ninja (reasonably) does not like. dlldata.c is a generated file name that a bunch of idl build rules output but most do not actually compile it AFAICT. This was causing some targets in isimpledom (that contain multiple idl files) to output to the same name (dlldata.c), so uniquize it based on InputName. For the one target that seems to actually build dlldata.c, override back to the original name to keep things the same (iaccessible2). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131232

Patch Set 1 #

Patch Set 2 : remove installer from this CL #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/iaccessible2/iaccessible2.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10008061/2001

8 years, 8 months ago (2012-04-06 22:13:18 UTC) #3

Change committed as 131232

Expand Messages | Collapse Messages