Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 10008058: Remove obsolete chromeos specific code (Closed)

Created:
8 years, 8 months ago by oshima
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove obsolete chromeos specific code BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131423

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -203 lines) Patch
M chrome/app/chrome_command_ids.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/chrome_exe_main_gtk.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_util.h View 1 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/simple_message_box_gtk.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/test_browser_window.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M printing/printed_document_gtk.cc View 1 2 3 3 chunks +1 line, -3 lines 0 comments Download
D ui/base/gtk/tooltip_window_gtk.h View 1 1 chunk +0 lines, -58 lines 0 comments Download
D ui/base/gtk/tooltip_window_gtk.cc View 1 1 chunk +0 lines, -96 lines 0 comments Download
M ui/ui.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
oshima
8 years, 8 months ago (2012-04-06 20:57:19 UTC) #1
Emmanuel Saint-loubert-Bié
lgtm
8 years, 8 months ago (2012-04-06 21:35:54 UTC) #2
oshima
requesting owners approval erg -> chrome/browser/ui/gtk thestig -> printing sky -> ui/ , chrome/ except ...
8 years, 8 months ago (2012-04-07 00:39:26 UTC) #3
sky
LGTM
8 years, 8 months ago (2012-04-09 14:19:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10008058/5035
8 years, 8 months ago (2012-04-09 16:28:03 UTC) #5
commit-bot: I haz the power
Presubmit check for 10008058-5035 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-09 16:28:13 UTC) #6
oshima
Oops, forgot about printing/. Adding thestig for printing/ On 2012/04/09 16:28:13, I haz the power ...
8 years, 8 months ago (2012-04-09 18:03:50 UTC) #7
Lei Zhang
printing/ LGTM, since you won't be using printed_document_gtk.cc, right? On 2012/04/09 18:03:50, oshima wrote: > ...
8 years, 8 months ago (2012-04-09 18:44:18 UTC) #8
oshima
On 2012/04/09 18:44:18, Lei Zhang wrote: > printing/ LGTM, since you won't be using printed_document_gtk.cc, ...
8 years, 8 months ago (2012-04-09 18:55:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10008058/5035
8 years, 8 months ago (2012-04-09 18:56:21 UTC) #10
commit-bot: I haz the power
8 years, 8 months ago (2012-04-09 20:31:20 UTC) #11
Change committed as 131423

Powered by Google App Engine
This is Rietveld 408576698