webkit/fileapi/file_system_operation_write_unittest.cc - Issue 10008047: FileWriterDelegate should not call URLRequest::Start() after Cancel().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webkit/fileapi/file_system_operation_write_unittest.cc

Issue 10008047: FileWriterDelegate should not call URLRequest::Start() after Cancel(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: reverted the test Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « webkit/fileapi/file_system_operation.cc ('k') | webkit/fileapi/file_writer_delegate.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //	4 //

5 // NOTE: These tests are run as part of "unit_tests" (in chrome/test/unit)	5 // NOTE: These tests are run as part of "unit_tests" (in chrome/test/unit)

6 // rather than as part of test_shell_tests because they rely on being able	6 // rather than as part of test_shell_tests because they rely on being able

7 // to instantiate a MessageLoop of type TYPE_IO. test_shell_tests uses	7 // to instantiate a MessageLoop of type TYPE_IO. test_shell_tests uses

8 // TYPE_UI, which URLRequest doesn't allow.	8 // TYPE_UI, which URLRequest doesn't allow.

9 //	9 //

10	10

(...skipping 373 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
384 url_request_context->blob_storage_controller()->RemoveBlob(blob_url);	384 url_request_context->blob_storage_controller()->RemoveBlob(blob_url);

385	385

386 // Issued Cancel() before receiving any response from Write(),	386 // Issued Cancel() before receiving any response from Write(),

387 // so nothing should have happen.	387 // so nothing should have happen.

388 EXPECT_EQ(0, bytes_written());	388 EXPECT_EQ(0, bytes_written());

389 EXPECT_EQ(base::PLATFORM_FILE_ERROR_ABORT, status());	389 EXPECT_EQ(base::PLATFORM_FILE_ERROR_ABORT, status());

390 EXPECT_EQ(base::PLATFORM_FILE_OK, cancel_status());	390 EXPECT_EQ(base::PLATFORM_FILE_OK, cancel_status());

391 EXPECT_TRUE(complete());	391 EXPECT_TRUE(complete());

392 }	392 }

393	393

394 // TODO(ericu,dmikurube): Add more tests for Cancel.	394 // TODO(ericu,dmikurube,kinuko): Add more tests for cancel cases.

395	395

396 } // namespace fileapi	396 } // namespace fileapi

OLD	NEW