Issue 100076: Switching to v8.gyp in the v8 project (so they can maintain it themselves).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100076: Switching to v8.gyp in the v8 project (so they can maintain it themselves). (Closed)

Created:
11 years, 8 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Switching to v8.gyp in the v8 project (so they can maintain it themselves). Rolling forward v8 version to pull in one with v8.gyp. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14786

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -51 lines)			Patch
M	DEPS	View	3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
M	build/all.gyp	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.sln	View	1 2 3 4 5 6	13 chunks	+22 lines, -25 lines	0 comments	Download
M	net/net.gyp	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/webkit.gyp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/webkit.sln	View	1 2 3 4 5 6	10 chunks	+18 lines, -21 lines	0 comments	Download

Total messages: 5 (0 generated)

Craig Schlenter

You need to change webkit.gyp too I think: http://codereview.chromium.org/99056

11 years, 8 months ago (2009-04-28 16:49:04 UTC) #1

bradn

On 2009/04/28 16:49:04, Craig Schlenter wrote: > You need to change webkit.gyp too I think: ...

11 years, 8 months ago (2009-04-28 20:57:25 UTC) #2

Looks fine.