Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 100074: stdafx for precompiled stdafx generation in media player. (Closed)

Created:
11 years, 8 months ago by fbarchard
Modified:
9 years, 7 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

stdafx for precompiled stdafx generation in media player. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14694

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 6

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
A media/player/stdafx.h View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A media/player/stdafx.cc View 1 2 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fbarchard
Got time for an easy review?
11 years, 8 months ago (2009-04-27 22:26:32 UTC) #1
Alpha Left Google
http://codereview.chromium.org/100074/diff/1004/1006 File media/player/stdafx.cc (right): http://codereview.chromium.org/100074/diff/1004/1006#newcode6 Line 6: // This file is in Microsoft coding style ...
11 years, 8 months ago (2009-04-27 22:29:56 UTC) #2
fbarchard
done http://codereview.chromium.org/100074/diff/1004/1006 File media/player/stdafx.cc (right): http://codereview.chromium.org/100074/diff/1004/1006#newcode6 Line 6: // This file is in Microsoft coding ...
11 years, 8 months ago (2009-04-27 23:03:05 UTC) #3
fbarchard
Does it look good yet?
11 years, 8 months ago (2009-04-28 00:35:44 UTC) #4
Alpha Left Google
11 years, 8 months ago (2009-04-28 00:36:41 UTC) #5 
LGTM! Sorry for the delay!

Powered by Google App Engine
This is Rietveld 408576698