Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: remoting/host/host_config.h

Issue 10007048: Cleanup and simplify HostConfig and JsonHostConfig. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/host_config.h
diff --git a/remoting/host/host_config.h b/remoting/host/host_config.h
index 4c7ed7765a9a70040ac43207828bb68377c4fda6..0edbb9caa8e8272c262fe375002cc64cf3f6682a 100644
--- a/remoting/host/host_config.h
+++ b/remoting/host/host_config.h
@@ -7,7 +7,7 @@
#include <string>
-#include "base/memory/ref_counted.h"
+#include "base/basictypes.h"
namespace remoting {
@@ -34,14 +34,16 @@ extern const char kHostSecretHashConfigPath[];
extern const char kPrivateKeyConfigPath[];
// HostConfig interace provides read-only access to host configuration.
-class HostConfig : public base::RefCountedThreadSafe<HostConfig> {
+class HostConfig {
public:
HostConfig() {}
virtual ~HostConfig() {}
- virtual bool GetString(const std::string& path, std::string* out_value) = 0;
- virtual bool GetBoolean(const std::string& path, bool* out_value) = 0;
+ virtual bool GetString(const std::string& path,
+ std::string* out_value) const = 0;
+ virtual bool GetBoolean(const std::string& path, bool* out_value) const = 0;
+ private:
DISALLOW_COPY_AND_ASSIGN(HostConfig);
};
@@ -57,7 +59,7 @@ class MutableHostConfig : public HostConfig {
virtual void SetBoolean(const std::string& path, bool in_value) = 0;
// Save's changes.
Lambros 2012/04/06 22:26:46 nit: "Save" or "Saves", no apostrophe.
Sergey Ulanov 2012/04/06 22:32:53 Done.
- virtual void Save() = 0;
+ virtual bool Save() = 0;
DISALLOW_COPY_AND_ASSIGN(MutableHostConfig);
};

Powered by Google App Engine
This is Rietveld 408576698