Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 10007010: Add BrowserThread::PostBlockingTaskAndReply. (Closed)

Created:
8 years, 8 months ago by willchan no longer on Chromium
Modified:
8 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add BrowserThread::PostBlockingTaskAndReply. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131352

Patch Set 1 #

Total comments: 2

Patch Set 2 : Oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M content/browser/browser_thread_impl.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M content/public/browser/browser_thread.h View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
willchan no longer on Chromium
8 years, 8 months ago (2012-04-05 16:27:39 UTC) #1
jam
http://codereview.chromium.org/10007010/diff/1/content/browser/browser_thread_impl.cc File content/browser/browser_thread_impl.cc (right): http://codereview.chromium.org/10007010/diff/1/content/browser/browser_thread_impl.cc#newcode233 content/browser/browser_thread_impl.cc:233: return g_globals.Get().blocking_pool->PostWorkerTask(from_here, task); did you mean to call PostTaskAndReply?
8 years, 8 months ago (2012-04-05 17:46:53 UTC) #2
willchan no longer on Chromium
http://codereview.chromium.org/10007010/diff/1/content/browser/browser_thread_impl.cc File content/browser/browser_thread_impl.cc (right): http://codereview.chromium.org/10007010/diff/1/content/browser/browser_thread_impl.cc#newcode233 content/browser/browser_thread_impl.cc:233: return g_globals.Get().blocking_pool->PostWorkerTask(from_here, task); On 2012/04/05 17:46:53, John Abd-El-Malek wrote: ...
8 years, 8 months ago (2012-04-06 16:28:44 UTC) #3
jam
lgtm
8 years, 8 months ago (2012-04-06 19:55:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/willchan@chromium.org/10007010/1003
8 years, 8 months ago (2012-04-09 12:11:54 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-09 13:26:41 UTC) #6
Change committed as 131352

Powered by Google App Engine
This is Rietveld 408576698